RFR: 8351842: Windows specific issues in combination of JEP 493 and --with-external-symbols-in-bundles=public

[Christoph Langer]

On Fri, 14 Mar 2025 14:10:30 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Alternative approach to #24012
>> 
>> This keeps the current handling of *.pdb vs *.stripped.pdb which allows debugging at the cost of a little hack in jlink. Maybe the code in jlink can be improved, e.g. make it more conditional.
>> 
>> I'm running this through our testing still to see whether it'll resolve all of the test issues and does not introduce regressions.
>
> make/Bundles.gmk line 248:
> 
>> 246:           %.stripped.pdb, \
>> 247:           $(call FindFiles, $(SYMBOLS_IMAGE_DIR)) \
>> 248:       )
> 
> Why filter *.stripped.pdb? Because they are useless for debugging? Then it should be mentioned as a comment.

This is fixing a small issue that is independent of JEP 493. Currently the JDK/JRE bundles contain the lib.stripped.pdb files renamed to lib.pdb. The symbols bundle contains these as well but it should have the full lib.pdb files. So, by filtering out *stripped.pdb during the creation of the symbols bundle, we make sure that the full pdb files end up in the symbols bundle.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24057#discussion_r1998173085