RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v2]

Joe Wang joehw at openjdk.org
Wed Mar 19 00:43:28 UTC 2025


On Tue, 18 Mar 2025 19:05:32 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update the test: change variables and etc.
>
> test/jaxp/javax/xml/jaxp/unittest/common/jdkcatalog/JDKCatalogTest.java line 143:
> 
>> 141:     public void testDTDsInJDKCatalog(String publicId, String systemId) {
>> 142:         String matchingPubId = JDKCATALOG.matchPublic(publicId);
>> 143:         String matchingSysId = JDKCATALOG.matchSystem(systemId);
> 
> Isn't there a public API to get these values. It seems a bit of a hack to have to break module encapsulation.

Updated. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24039#discussion_r2002201631


More information about the core-libs-dev mailing list