RFR: 8351842: Windows specific issues in combination of JEP 493 and --with-external-symbols-in-bundles=public

[Severin Gehwolf]

On Mon, 17 Mar 2025 08:27:20 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Alternative approach to #24012
>> 
>> This keeps the current handling of *.pdb vs *.stripped.pdb which allows debugging at the cost of a little hack in jlink. Maybe the code in jlink can be improved, e.g. make it more conditional.
>> 
>> I'm running this through our testing still to see whether it'll resolve all of the test issues and does not introduce regressions.
>
> After running this patch through our testing I can confirm that it at least solves all existing test issues and does not create regressions.
> 
> I, however, admit that the added code in JRTArchive.java is quite hacky and is actually only there to solve some testing issues, not great. Can we maybe add a possibility to store two alternative SHA sums in the JMod archives, per file? Then we could add SHA sums for both, the stripped and the full pdb file and either one which is present in the current runtime would be accepted. So we'd cover the cases where the stripped pdb files are around as well as a potential case when somebody extracted the symbols archive over the runtime.

@RealCLanger I can take a stab at this if you don't mind.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24057#issuecomment-2741191433