RFR: 8319447: Improve performance of delayed task handling [v12]
Doug Lea
dl at openjdk.org
Tue Mar 25 18:41:34 UTC 2025
On Tue, 25 Mar 2025 15:14:56 GMT, Viktor Klang <vklang at openjdk.org> wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 47 additional commits since the last revision:
>>
>> - Merge branch 'openjdk:master' into JDK-8319447
>> - Match indent of naster changes
>> - Use TC_MASK in accord with https://bugs.openjdk.org/browse/JDK-8330017 (Unnecessarily for now.)
>> - Reword javadoc
>> - Use SharedSecrets for ThreadLocalRandomProbe; other tweaks
>> - Disambiguate caller-runs vs Interruptible
>> - Merge branch 'openjdk:master' into JDK-8319447
>> - Associate probes with carriers if Virtual (no doc updates yet)
>> - Reduce volatile reads
>> - Address review comments; reactivation tweak
>> - ... and 37 more: https://git.openjdk.org/jdk/compare/fd6e7e14...b552c225
>
> src/java.base/share/classes/java/util/concurrent/DelayScheduler.java line 434:
>
>> 432: if (n > 0)
>> 433: cancelAll(h, n);
>> 434: for (ScheduledForkJoinTask<?> a = (ScheduledForkJoinTask<?>)
>
> @DougLea Is there any risk here for a late writer to PENDING to append *after* this loop completes?
No. Pool status is already STOP at this point, so no new requests will appear.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r2012733609
More information about the core-libs-dev
mailing list