RFR: 8334322: Misleading values of keys in jpackage resource bundle
Alexander Matveev
almatvee at openjdk.org
Tue Mar 25 18:55:22 UTC 2025
On Tue, 25 Mar 2025 03:19:39 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
> Replace `error.invalid-value-for-package-name` and `error.invalid-value-for-package-name.advice` l10n keys with a pair for rpm packaging:
> - `error.rpm-invalid-value-for-package-name`
> - `error.rpm-invalid-value-for-package-name.advice`
> and a pair for deb packaging:
> - `error.deb-invalid-value-for-package-name`
> - `error.deb-invalid-value-for-package-name.advice`
>
> Added tests for the new l10n keys.
> Altered jdk.jpackage.internal.Arguments class to prevent it from suppressing the advice property of wrapped `jdk.jpackage.internal.ConfigException` exceptions.
Looks good.
-------------
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24215#pullrequestreview-2714867877
More information about the core-libs-dev
mailing list