RFR: 8319447: Improve performance of delayed task handling [v12]

Doug Lea dl at openjdk.org
Tue Mar 25 19:01:26 UTC 2025


On Tue, 25 Mar 2025 16:40:57 GMT, Viktor Klang <vklang at openjdk.org> wrote:

>> Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 47 additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into JDK-8319447
>>  - Match indent of naster changes
>>  - Use TC_MASK in accord with https://bugs.openjdk.org/browse/JDK-8330017 (Unnecessarily for now.)
>>  - Reword javadoc
>>  - Use SharedSecrets for ThreadLocalRandomProbe; other tweaks
>>  - Disambiguate caller-runs vs Interruptible
>>  - Merge branch 'openjdk:master' into JDK-8319447
>>  - Associate probes with carriers if Virtual (no doc updates yet)
>>  - Reduce volatile reads
>>  - Address review comments; reactivation tweak
>>  - ... and 37 more: https://git.openjdk.org/jdk/compare/74638b60...b552c225
>
> test/jdk/java/util/concurrent/tck/ForkJoinPool20Test.java line 456:
> 
>> 454:                             if (elapsedMillis >= 2 * d)
>> 455:                                 tryLongerDelay.set(true);
>> 456:                         }
> 
> Suggestion:
> 
>                             if (elapsedMillis >= (done.getCount() == cycles ? d : 2 * d))
>                                 tryLongerDelay.set(true);

Done. Thanks for simplifying result of a couple of layers of copy/paste/hack!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r2012760334


More information about the core-libs-dev mailing list