RFR: 8351435: Change the default Console implementation back to the built-in one in `java.base` module [v2]
Naoto Sato
naoto at openjdk.org
Wed Mar 26 17:15:13 UTC 2025
On Wed, 26 Mar 2025 13:09:16 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Reflects review comment
>
> test/jdk/java/io/IO/IO.java line 166:
>
>> 164: var file = Path.of(System.getProperty("test.src", "."), "Output.java")
>> 165: .toAbsolutePath().toString();
>> 166: var pb = ProcessTools.createTestJavaProcessBuilder("-Djdk.console=jdk.internal.le", "--enable-preview", file, mode);
>
> Have you looked into changing the test so that it runs twice, the second with the jline provider?
The child java process `Output.java` calls `System.console()`, so the launcher has to be run with `-Djdk.console=jdk.internal.le`, otherwise NPE is thrown in `Output.java`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23993#discussion_r2014640886
More information about the core-libs-dev
mailing list