RFR: 8319447: Improve performance of delayed task handling [v13]
Doug Lea
dl at openjdk.org
Wed Mar 26 19:55:23 UTC 2025
On Wed, 26 Mar 2025 13:14:08 GMT, Viktor Klang <vklang at openjdk.org> wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 49 commits:
>>
>> - Merge branch 'openjdk:master' into JDK-8319447
>> - Address review comments
>> - Merge branch 'openjdk:master' into JDK-8319447
>> - Match indent of naster changes
>> - Use TC_MASK in accord with https://bugs.openjdk.org/browse/JDK-8330017 (Unnecessarily for now.)
>> - Reword javadoc
>> - Use SharedSecrets for ThreadLocalRandomProbe; other tweaks
>> - Disambiguate caller-runs vs Interruptible
>> - Merge branch 'openjdk:master' into JDK-8319447
>> - Associate probes with carriers if Virtual (no doc updates yet)
>> - ... and 39 more: https://git.openjdk.org/jdk/compare/dbc620fb...4aabe6b0
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3932:
>
>> 3930: * @since 25
>> 3931: */
>> 3932: public int getDelayedTaskCount() {
>
> @DougLea It would seem more consistent to have this return a `long` like `getQueuedTaskCount` (even if that amount isn't currently possible to represent in the heap. Thoughts, @AlanBateman?
Arguably better, but not sure it is worth regenerating diffs for? (An int was used for the same reason as in FJT.getQueueSize -- they need to be valid array bounds. Which might someday allow long, but if so many things would change.)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r2014907721
More information about the core-libs-dev
mailing list