RFR: 8352755: Misconceptions about j.text.DecimalFormat digits during parsing [v2]

Justin Lu jlu at openjdk.org
Wed Mar 26 23:05:46 UTC 2025


On Wed, 26 Mar 2025 22:35:25 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> That commentary is only in this method because of the non-obvious behavior for the maximum integer digits. (The pattern does not change the `maximumIntegerDigits`). Since not all users may read that section in the class description, that is why this method has the explicit call-out, so I think it may be beneficial to keep this wording. I am fine either way, if you don't think it's worth it, I'll remove.
>
> If there is some oddity in this getter, would it be helpful if we add more to it, eg, "Unlike other getter methods..."?

That's a good point, it should be phrased as a call out the unique behavior. New wording is also more concise. Changed in https://github.com/openjdk/jdk/pull/24265/commits/5fc8f37f951555a48b78a133a528e298faabd9b7.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24265#discussion_r2015104518


More information about the core-libs-dev mailing list