RFR: 8352906: stdout/err.encoding on Windows set by incorrect Win32 call [v3]

Brian Burkhalter bpb at openjdk.org
Thu Mar 27 16:39:08 UTC 2025


On Thu, 27 Mar 2025 16:03:08 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Those system property values on Windows were derived from Windows' `GetConsoleCP()` call, but they should have been taken from `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one won't change any behavior, as both calls return the same value by default (`GetOEMCP()`). However, it is still the right thing to do.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Handled the error case

Review error handling case.

-------------

Marked as reviewed by bpb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24263#pullrequestreview-2722569603


More information about the core-libs-dev mailing list