RFR: 8353196: [macos] Contents of ".jpackage.xml" file are wrong when building .pkg from unsigned app image [v2]
Alexey Semenyuk
asemenyuk at openjdk.org
Mon Mar 31 14:43:37 UTC 2025
> - Don't create ".jpackage.xml" file in image for DNG or PKG bundles;
> - Remove ".jpackage.xml" file from unsigned predefined app image for DNG or PKG bundles;
> - Set the value of `signed` property in ".jpackage.xml" file to "true" only in the app image itself is signed.
Alexey Semenyuk has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
- Merge branch 'master' into JDK-8353196-full
- Fix JPackageCommand.macAppImageSigned() and move it together with JPackageCommand.signPredefinedAppImage() to MacHelper class
- Strip ".jpackage.xml" from copied app image when permitted
- Don't create app image file on macOS when not needed
- Adjust JPackageCommand.assertAppImageFile()
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24313/files
- new: https://git.openjdk.org/jdk/pull/24313/files/b3c387ba..31fff85d
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24313&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24313&range=00-01
Stats: 7391 lines in 112 files changed: 4399 ins; 2620 del; 372 mod
Patch: https://git.openjdk.org/jdk/pull/24313.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24313/head:pull/24313
PR: https://git.openjdk.org/jdk/pull/24313
More information about the core-libs-dev
mailing list