RFR: 8352480: Don't follow symlinks in additional content for app images

Mikhail Yankelevich myankelevich at openjdk.org
Thu May 1 21:27:48 UTC 2025


On Wed, 30 Apr 2025 20:17:57 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> - Symbolic links will not be followed for `--app-content` on all platforms.
> - Added test to cover this case.
> - `MacHelper` updated to use "cp -R" instead of "cp -r" when unpacking DMG, since "cp -r" on macOS is not documented option and when used `cp` will follow symbolic links which breaks test. "cp -R" does not follow symbolic links.

test/jdk/tools/jpackage/share/AppContentTest.java line 57:

> 55:  */
> 56: public class AppContentTest {
> 57: 

Nitpick: do you think it might be worth it to add a bug id to the `@test`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24974#discussion_r2070827582


More information about the core-libs-dev mailing list