RFR: 8355443: [java.io] Use @requires tag instead of exiting based on File.separatorChar value [v2]

Naoto Sato naoto at openjdk.org
Fri May 2 16:43:46 UTC 2025


On Fri, 2 May 2025 16:05:05 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> For tests of the `java.io` package, instead of doing this
>> 
>>     public static void main(String[] args) throws Exception {
>>         if (File.separatorChar != '\') {
>>             /* This test is only valid on win32 systems */
>>             return;
>>         }
>> 
>> do this
>> 
>>    @requires (os.family == "windows")
>
> Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Merge
>  - 8355443: [java.io] Use @requires tag instead of exiting based on File.separatorChar value

LGTM

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24838#pullrequestreview-2812461982


More information about the core-libs-dev mailing list