RFR: 8353489: Increase timeout and improve Windows compatibility in test/jdk/java/lang/ProcessBuilder/Basic.java [v2]

[Oleksii Sylichenko]

On Sat, 3 May 2025 12:19:54 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> Oleksii Sylichenko has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8353489: replace `echo.` with `echo/`
>
> test/jdk/java/lang/ProcessBuilder/Basic.java line 1843:
> 
>> 1841:         //----------------------------------------------------------------
>> 1842:         try {
>> 1843:             String[] cmdp = Windows.is() ? new String[]{"cmd", "/c", "echo/"} : new String[]{"echo"};
> 
> A future maintainer without intimate familiarity with Windows commands and syntax would probably appreciate a short comment explaining the command chosen.

Would a comment with the following text be sufficient:

In Windows CMD (`cmd.exe`), `echo/` outputs a newline (i.e., an empty line).
Wrapping it with `cmd.exe /c` ensures compatibility in both native Windows and Cygwin environments.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23933#discussion_r2072388153