RFR: 8355536: Create version constants to model preview language and vm features [v2]
Luca Kellermann
duke at openjdk.org
Sun May 4 20:35:53 UTC 2025
On Sun, 4 May 2025 20:29:18 GMT, Chen Liang <liach at openjdk.org> wrote:
>> src/java.base/share/classes/java/lang/reflect/ClassFileFormatVersion.java line 413:
>>
>>> 411: * ensure the program is compatible with future Java SE releases.
>>> 412: * <p>
>>> 413: * This is a reflective preview API to allows tools running in Java runtime
>>
>> Suggestion:
>>
>> * This is a reflective preview API that allows tools running in Java runtime
>
> Don't know why you recommend this, but this aims to explain why this API is reflective preview API instead of an essential preview API (that does not have `reflective = true`). Particular tools wish to perform this specific check, like `javap`; otherwise, I would have marked this as non-reflective, and tools must resort to a third-party knowledge pool to parse preview features related to the current release.
It sounded wrong, maybe "to allow" (without 's') would be better.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25017#discussion_r2072705126
More information about the core-libs-dev
mailing list