RFR: 8351443: Improve robustness of StringBuilder [v5]

Brent Christian bchristi at openjdk.org
Mon May 5 21:37:48 UTC 2025


On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Refactor AbstractStringBuilder to maintain consistency among count, coder, and value buffers while the buffer capacity is being expanded and/or inflated from Latin1 to UTF16 representations. 
>> The refactoring pattern is to read and write AbstractStringBuilder fields once using locals for all intermediate values. 
>> Support methods are static, designed to pass all values as arguments and return a value.
>> 
>> The value byte array is reallocated under 3 conditions:
>> - Increasing the capacity with the same encoder
>> - Increasing the capacity and inflation to change the coder from LATIN1 to UTF16
>> - Inflation with the same capacity
>> 
>> Added StressSBTest to exercise public instance methods of StringBuilder.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Refactor to consistently use `isLatin1(coder)` within AbstractStringBuilder.

src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 335:

> 333:      *
> 334:      * @param  minCapacity the desired minimum capacity
> 335:      * @throws OutOfMemoryError if minCapacity is less than zero or

new `@params` for added arguments?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24967#discussion_r2074232727


More information about the core-libs-dev mailing list