RFR: 8355573: Remove kludge_c++11.h from jpackage code

Julian Waters jwaters at openjdk.org
Tue May 6 00:52:12 UTC 2025


On Mon, 5 May 2025 22:23:04 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> kludge_c++11.h was introduced to work around older C++ versions not having access to C++ utilities like std::unique_ptr. Since we are already on C++14 (And hopefully will get C++17 soon) this workaround can be removed from jpackage code.
>
> src/jdk.jpackage/windows/native/common/MsiUtils.h line 35:
> 
>> 33: #include <new>
>> 34: #include <map>
>> 35: #include <memory>
> 
> Why this include was added?

It seemed to be needed to compile successfully back when I removed the kludge header (I couldn't figure out why). I can try again without the memory include using GitHub Actions to test instead if that is preferred.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24868#discussion_r2074480472


More information about the core-libs-dev mailing list