RFR: 8356126: Duplication handling and optimization of CaptureCallState [v9]

Jorn Vernee jvernee at openjdk.org
Tue May 6 22:21:16 UTC 2025


On Tue, 6 May 2025 22:11:49 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Credit to @lukellmann that the duplication arg handling in #24742 avoided throwing exceptions but produced a wrong option. This patch fixes that and removed stream usages in CaptureCallState to speed up bootstrap.
>> 
>> Also, the previous patch affected the toString display of the option; I added a unit test to ensure the option prints names that is user-friendly.
>> 
>> Another thing I noted is `CapturableState` uses `OperatingSystem`; using `valueOf` brings a performance overhead due to setups with reflection, so I made this lazy. (The enum is thread safe, so we allow racy access to the cache field)
>> 
>> Testing: jdk/lang/foreign, tier 1-3 in progress.
>
> Chen Liang has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Indicate source file
>  - Keep in sync comments

Marked as reviewed by jvernee (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25025#pullrequestreview-2819834200


More information about the core-libs-dev mailing list