RFR: 8352480: Don't follow symlinks in additional content for app images [v2]
Shaojin Wen
swen at openjdk.org
Wed May 7 01:53:20 UTC 2025
On Wed, 7 May 2025 01:34:13 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
>> - Symbolic links will not be followed for `--app-content` on all platforms.
>> - Added test to cover this case.
>> - `MacHelper` updated to use "cp -R" instead of "cp -r" when unpacking DMG, since "cp -r" on macOS is not documented option and when used `cp` will follow symbolic links which breaks test. "cp -R" does not follow symbolic links.
>
> Alexander Matveev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Merge remote-tracking branch 'upstream/master' into JDK-8352480
> - 8352480: [macos] Don't follow symlinks in additional content for app images [v4]
> - 8352480: [macos] Don't follow symlinks in additional content for app images [v3]
> - 8352480: [macos] Don't follow symlinks in additional content for app images [v2]
> - 8352480: [macos] Don't follow symlinks in additional content for app images
test/jdk/tools/jpackage/share/AppContentTest.java line 37:
> 35: import java.util.stream.Stream;
> 36: import static jdk.internal.util.OperatingSystem.MACOS;
> 37: import static jdk.internal.util.OperatingSystem.LINUX;
Should the imports here be sorted?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24974#discussion_r2076636260
More information about the core-libs-dev
mailing list