RFR: 8341184: Clean up the interaction between the launcher native code and the LauncherHelper [v16]

[Chen Liang]

On Wed, 7 May 2025 07:34:32 GMT, Shaojin Wen <swen at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
>> 
>>  - merge latest from master branch
>>  - merge latest from master branch
>>  - merge latest from master branch
>>  - merge latest from master branch
>>  - merge latest from master branch
>>  - merge latest from master branch
>>  - merge latest from master branch
>>  - merge latest from master branch
>>  - merge latest from master branch
>>  - merge latest from master branch
>>  - ... and 6 more: https://git.openjdk.org/jdk/compare/e410af00...d1ac5174
>
> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 946:
> 
>> 944:                         JAVAFX_APPLICATION_CLASS_NAME);
>> 945:             }
>> 946:         }
> 
> Suggestion:
> 
>         if (!PreviewFeatures.isEnabled()) {
>             int mods = mainMethod.getModifiers();
>             if (!Modifier.isStatic(mods) || !Modifier.isPublic(mods) || mainMethod.getParameterCount() == 0) {
>                 abort(null, "java.launcher.cls.error2", builder.mainClass.getName(),
>                         JAVAFX_APPLICATION_CLASS_NAME);
>             }
>         }
> 
> Remove variables that are only used once

This can now be removed. Compact source files and instance main methods have been integrated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21256#discussion_r2077717832