RFR: 8354799: ZipInputStream doesn't verify CRC for empty ZipEntry

Alan Bateman alanb at openjdk.org
Thu May 8 13:03:53 UTC 2025


On Thu, 8 May 2025 12:08:09 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which addresses the issue noted in https://bugs.openjdk.org/browse/JDK-8354799?
> 
> `java.util.zip.ZipInputStream` when dealing with a `STORED` entry of zero size was missing a CRC check for that entry. The change in this PR addresses that and introduces a new jtreg test which reproduces the issue and verifies the fix.
> 
> tier testing is currently in progress.

Do you have any sense on whether there are JAR files in use that have wrong CRCs for empty entries? I'm just wondering if there are any wonky tools or plugins in the eco system, the output of which could be impacted by the more strict check.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25116#issuecomment-2862971376


More information about the core-libs-dev mailing list