RFR: 8356080: Address post-integration comments for Stable Values

[Stuart Marks]

On Fri, 2 May 2025 12:13:39 GMT, Per Minborg <pminborg at openjdk.org> wrote:

> This PR proposes to address comments in the initial PR for Stable Values, which were deferred until after integration.
> 
> Unfortunately, this PR shows the total commit history for stable values.

src/java.base/share/classes/java/util/ImmutableCollections.java line 954:

> 952:                 return deepRoot(sub.root);
> 953:             }
> 954:             throw new InternalError("Should not reach here: " + list.getClass().getName());

Does this need to be recursive? There is logic to avoid nesting of sublists, and a sublist of a reversed view should end up being a reversed view of a sublist, so the most deep nesting that can occur is reversed(sublist(base)).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25004#discussion_r2080034660