RFR: 8348828: Windows dll loading now resolves symlinks [v2]
Benjamin Peterson
duke at openjdk.org
Thu May 8 17:43:31 UTC 2025
> Deep in the bowels of `System.loadLibrary`, `File.getCanonicalPath()` is called on the target library file before it is passed to the system library loading APIs. In JDK-8003887, `File.getCanonicalPath` was altered to resolve symlinks on Windows. This had unintended consequences for passing a symlink to `System.loadLibrary` on Windows. The underlying Windows `LoadLibrary` API inspects the file name passed to it and adds a `.dll` extension if the it is not already present. Thus, if `System.loadLibrary` was given a symlink to a file and that file didn't have a `.dll` extension, `LoadLibrary` try to load nonexistent file and fail.
>
> Fix this problem by appending a `.` to library paths after canonicalization on Windows. This trailing dot inhibits `LoadLibrary`'s own appending behavior.
Benjamin Peterson has updated the pull request incrementally with one additional commit since the last revision:
new approach: append . to file name on Windows
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24694/files
- new: https://git.openjdk.org/jdk/pull/24694/files/46040f1f..f16626be
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24694&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24694&range=00-01
Stats: 22 lines in 5 files changed: 21 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/24694.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24694/head:pull/24694
PR: https://git.openjdk.org/jdk/pull/24694
More information about the core-libs-dev
mailing list