RFR: 8352480: Don't follow symlinks in additional content for app images [v3]
Alexander Matveev
almatvee at openjdk.org
Fri May 9 01:40:50 UTC 2025
On Wed, 7 May 2025 02:07:03 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
>> - Symbolic links will not be followed for `--app-content` on all platforms.
>> - Added test to cover this case.
>> - `MacHelper` updated to use "cp -R" instead of "cp -r" when unpacking DMG, since "cp -r" on macOS is not documented option and when used `cp` will follow symbolic links which breaks test. "cp -R" does not follow symbolic links.
>
> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>
> 8352480: [macos] Don't follow symlinks in additional content for app images [v5]
8352480: [macos] Don't follow symlinks in additional content for app images [v6]
- Fixed latest comments.
- Link will be created under "Links" folder to avoid confusion with reusing "Resources"
- Link creation moved under separate function `createAppContentLink` from `copyAppContentPath` to avoid confusion.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24974#issuecomment-2864851703
More information about the core-libs-dev
mailing list