RFR: 8354799: ZipInputStream doesn't verify CRC for ZIP entry with empty file data [v2]

Jaikiran Pai jpai at openjdk.org
Fri May 9 07:07:38 UTC 2025


> Can I please get a review of this change which addresses the issue noted in https://bugs.openjdk.org/browse/JDK-8354799?
> 
> `java.util.zip.ZipInputStream` when dealing with a `STORED` entry of zero size was missing a CRC check for that entry. The change in this PR addresses that and introduces a new jtreg test which reproduces the issue and verifies the fix.
> 
> tier testing is currently in progress.

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  Lance's suggestion - use assertThrows()

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25116/files
  - new: https://git.openjdk.org/jdk/pull/25116/files/b2c011d1..0aea22fa

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25116&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25116&range=00-01

  Stats: 14 lines in 1 file changed: 2 ins; 5 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/25116.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25116/head:pull/25116

PR: https://git.openjdk.org/jdk/pull/25116


More information about the core-libs-dev mailing list