RFR: 8351996: Behavioral updates for ClassValue::remove [v13]
Chen Liang
liach at openjdk.org
Sat May 10 20:43:20 UTC 2025
> The recent patch #23866 makes calling `ClassValue::remove()` from `ClassValue::computeValue()` end up in infinite loops while fixing the stale value risk from the method.
>
> The proposed fix is to preserve the stale value risk fix, and update the remove-from-compute behavior from the original designated no-op behavior to throwing an exception, as the original behavior conflicts with the stale value fix.
>
> The implementation track the owner thread in promises (accessed in locked section); as a result, we can fail-fast on recursive removals from `computeValue`. I did not choose to use `ThreadTracker` as it is designed for single tracker and multiple threads, while this case here sees often just one thread, and the threads outlive the promise objects.
>
> Also updated the API specs for `remove` to more concisely describe the memory effects. Please review the associated CSR as well.
Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 22 additional commits since the last revision:
- Jaikiran comments, improve thread reference tracking, more documents
- Merge branch 'master' of https://github.com/openjdk/jdk into fix/classvalue-compute-remove
- Update src/java.base/share/classes/java/lang/ClassValue.java
Co-authored-by: Shaojin Wen <shaojin.wensj at alibaba-inc.com>
- Merge branch 'master' of https://github.com/openjdk/jdk into fix/classvalue-compute-remove
- Reviews from viktor
- Rewrite impl to follow the new simplified spec
- Merge branch 'master' of https://github.com/openjdk/jdk into fix/classvalue-compute-remove
- Try to simplify the model - use the finish of computeValue
- Test updates - remove repetition, test case for no stale installation
- Fix incorrect promise removal when unnecessary and add regression test
- ... and 12 more: https://git.openjdk.org/jdk/compare/c7a6f415...e24a1fd7
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24043/files
- new: https://git.openjdk.org/jdk/pull/24043/files/3d68f09a..e24a1fd7
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24043&range=12
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24043&range=11-12
Stats: 27783 lines in 969 files changed: 17000 ins; 6516 del; 4267 mod
Patch: https://git.openjdk.org/jdk/pull/24043.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24043/head:pull/24043
PR: https://git.openjdk.org/jdk/pull/24043
More information about the core-libs-dev
mailing list