RFR: 8354674: AArch64: Intrinsify Unsafe::setMemory [v3]
Andrew Haley
aph at openjdk.org
Mon May 12 10:06:51 UTC 2025
On Mon, 12 May 2025 09:48:03 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Stub stack frame
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 2619:
>
>> 2617:
>> 2618: __ bind(tail);
>> 2619: // __ add(count, count, 64);
>
> I can see why you commented this out (and prefer that to deleting it). However, a comment explaining why it is not needed might avoid maintainers being side-tracked.
Eh, people enjoy a little puzzle. OK.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25147#discussion_r2084323192
More information about the core-libs-dev
mailing list