RFR: 8353197: Document preconditions for JavaLangAccess methods [v4]

Volkan Yazici vyazici at openjdk.org
Mon May 12 10:17:48 UTC 2025


On Mon, 12 May 2025 08:52:00 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix copyright years
>
> src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 461:
> 
>> 459:      * make a copy.
>> 460:      */
>> 461:     Object stringConcat1(String[] constants);
> 
> Is this missing the `unchecked` prefix to the method name?

Fixed in 5da9465ce7f.

> src/java.base/share/classes/jdk/internal/util/HexDigits.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
> 
> Hello Volkan, this should be `2024, 2025, `

Fixed in f94af95d8d0.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24982#discussion_r2084345953
PR Review Comment: https://git.openjdk.org/jdk/pull/24982#discussion_r2084345343


More information about the core-libs-dev mailing list