RFR: 8356658: java/foreign/TestBufferStackStress2.java failed again with junit action timed out [v3]
Alan Bateman
alanb at openjdk.org
Mon May 12 10:47:52 UTC 2025
On Mon, 12 May 2025 10:30:31 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> This PR proposes to add a safety net around closing the executor. Apparently, in some rare configuration, the VT is not run/notified correctly.
>>
>> Not completing the test for such a configuration is unlikely to mask potential issues that this test is supposed to reveal.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>
> Rework solution
test/jdk/java/foreign/TestBufferStackStress2.java line 28:
> 26: *
> 27: * If the VM does not have continuations, then no VTs can ever be scheduled
> 28: * @requires vm.continuations
The comment isn't quite right. Virtual threads will still be scheduled, it's just that the OS scheduler will be used as each virtual thread is backed by an OS thread.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25177#discussion_r2084399659
More information about the core-libs-dev
mailing list