RFR: 8356080: Address post-integration comments for Stable Values [v2]
Luca Kellermann
duke at openjdk.org
Mon May 12 21:00:03 UTC 2025
On Fri, 9 May 2025 14:53:59 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 384 commits:
>>
>> - Fix an issue with toString on nested constructs
>> - Merge branch 'master' into jep502-followup
>> - Merge branch 'master' into jep502-followup
>> - Update src/java.base/share/classes/java/lang/StableValue.java
>>
>> Co-authored-by: Chen Liang <liach at openjdk.org>
>> - Simplify furhter
>> - Address comments in PR
>> - Merge master
>> - Remove unused method and add comment
>> - Address comments
>> - Merge branch 'master' into jep502-followup
>> - ... and 374 more: https://git.openjdk.org/jdk/compare/900b3ff7...3eebd504
>
> src/java.base/share/classes/java/util/ImmutableCollections.java line 1715:
>
>> 1713:
>> 1714: // For @ValueBased
>> 1715: static private <K, V> LazyMapIterator<K, V> of(StableMapEntrySet<K, V> outer) {
>
> Suggestion:
>
> private static <K, V> LazyMapIterator<K, V> of(StableMapEntrySet<K, V> outer) {
This doesn't seem to be resolved.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25004#discussion_r2085387406
More information about the core-libs-dev
mailing list