RFR: 8354724: Methods in java.io.Reader to read all characters and all lines [v18]
Alan Bateman
alanb at openjdk.org
Tue May 13 10:59:05 UTC 2025
On Mon, 12 May 2025 23:51:19 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 21 additional commits since the last revision:
>
> - 8354724: Attempt to further improve verbiage
> - Merge
> - Update src/java.base/share/classes/java/io/Reader.java
>
> 8354724: Apply suggested changes for readAllLines.
>
> Co-authored-by: Roger Riggs <Roger.Riggs at Oracle.com>
> - Update src/java.base/share/classes/java/io/Reader.java
>
> 8354724: Apply suggested changes for readAllAsString.
>
> Co-authored-by: Roger Riggs <Roger.Riggs at Oracle.com>
> - 8354724: Revert BufferedReader; simplify Reader changes removing overridable self-call; update test
> - 8354724: Fix potential NPE in test
> - 8354724: Fix readAllChars gaffe in Reader returned by Readed.of and account for it in test
> - 8354724: Improve test per reviewer comments
> - 8354724: Add missing toList(), tweak verbiage; update test
> - 8354724: Add Reader.readAllLines; test not yet updated
> - ... and 11 more: https://git.openjdk.org/jdk/compare/fa3173d5...1d811589
src/java.base/share/classes/java/io/Reader.java line 430:
> 428: * <p> The behavior for the case where the reader is
> 429: * <i>asynchronously closed</i>, or the thread interrupted during the
> 430: * read, is highly input stream specific, and therefore not specified.
The carry over of this paragraph needs to replace "input stream" with reader (same thing in the other method).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24728#discussion_r2086530955
More information about the core-libs-dev
mailing list