RFR: 8356420: Provide examples on wrapping System.in [v6]

Chen Liang liach at openjdk.org
Tue May 13 12:36:58 UTC 2025


On Tue, 13 May 2025 11:39:16 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed an erroneous curly brace
>
> src/java.base/share/classes/java/io/InputStreamReader.java line 59:
> 
>> 57:  *     new InputStreamReader(System.in, System.getProperty("stdin.encoding"));
>> 58:  * }
>> 59:  *
> 
> There are several places in the sources that still contain `new InputStreamReader(System.in)`. Shouldn't they be replaced with `new InputStreamReader(System.in, System.getProperty("stdin.encoding"))` too?)

How did you search for those sources? I searched for literal `System.in` and my comments are the only ones I could find in the JDK.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25155#discussion_r2086713392


More information about the core-libs-dev mailing list