RFR: 8355798: Implement JEP 514: Ahead-of-Time Command Line Ergonomics [v8]

[Vladimir Kozlov]

On Thu, 15 May 2025 03:15:23 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/runtime/arguments.cpp line 3060:
>> 
>>> 3058: }
>>> 3059: 
>>> 3060: static JavaVMOption* get_last_aotmode_arg(const JavaVMInitArgs* args) {
>> 
>> I don't like that we pollute `Arguments` code with AOT specific flags processing.
>> Can we move this into `CDSConfig`? Both these 2 new methods.
>> 
>> But I will agree if you want to keep it here. It is not critical.
>
> These two functions are for parsing `JDK_AOT_VM_OPTIONS`, so I think they belong to arguments.cpp. cdsConfig.cpp is a consumer of the options parsed by arguments.cpp.

okay

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24942#discussion_r2090168858