RFR: 8355954: File.delete removes read-only files (win) [v3]

[Alan Bateman]

On Fri, 2 May 2025 18:19:35 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> This change proposes to modify `java.io.File.delete()` so that regular files on Windows will not be deleted by default if their read-only attribute is set. A boolean-valued system compatibility property `jdk.io.File.deleteReadOnly` is defined to reinstate legacy behavior if desired.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8355954: Fix HashedPasswordFileTest failure due to obsolete read-only attribute being set

test/jdk/java/io/File/DeleteReadOnly.java line 61:

> 59:     @Test
> 60:     @Order(1)
> 61:     @EnabledOnOs({OS.AIX, OS.LINUX, OS.MAC})

Have you look at creating a simpler test that doesn't use Order. If you drop DIR and FILE then each test could create the file or directory as needed so there wouldn't be any dependency on order.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24977#discussion_r2090748506