RFR: 8350880: (zipfs) Add support for read-only zip file systems [v3]
David Beaumont
duke at openjdk.org
Thu May 15 17:42:52 UTC 2025
On Wed, 14 May 2025 16:39:18 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix comment based on current behaviour.
>
> test/jdk/jdk/nio/zipfs/NewFileSystemTests.java line 219:
>
>> 217: assertFalse(fs.isReadOnly());
>> 218: if (!"Default version".equals(Files.readString(fs.getPath("file.txt"), UTF_8))) {
>> 219: throw new RuntimeException("unexpected file content");
>
> could also consider
>
> fail("unexpected file content");
Oh thanks for spotting!
That's a hangover from when it was in the old-style test class (ZipFSTester or whatever it's called).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25178#discussion_r2091684373
More information about the core-libs-dev
mailing list