RFR: 8357016: Candidate main methods not computed properly [v2]

[Jan Lahoda]

On Fri, 16 May 2025 10:07:36 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding tests as suggested.
>
> test/jdk/tools/launcher/Arrrghs.java line 607:
> 
>> 605:         //private method with parameter, usable method without parameter:
>> 606:         createJar(new File("some.jar"), new File("Foo"),
>> 607:             "private static void main(String[] args){}",
> 
> Perhaps we should even include a instance method `private void main(String[] args) {}` to cover that case?

Done:
https://github.com/openjdk/jdk/pull/25256/commits/a351686d1aeb7a82f52141558ca7d2590cb7689f

> test/langtools/tools/javac/launcher/SourceLauncherTest.java line 794:
> 
>> 792:                           """
>> 793:                           public class WrongMainPrivate {
>> 794:                               private static void main(String[] args) {}
> 
> Same comment as in the other place, perhaps we should include a `private void main(String[] args) {}` too?

Done:
https://github.com/openjdk/jdk/pull/25256/commits/a351686d1aeb7a82f52141558ca7d2590cb7689f

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25256#discussion_r2092844131
PR Review Comment: https://git.openjdk.org/jdk/pull/25256#discussion_r2092844245