RFR: 8356891: Some code simplifications for basic BigIntegers' bit operations [v6]
Raffaello Giulietti
rgiulietti at openjdk.org
Fri May 16 11:47:54 UTC 2025
On Fri, 16 May 2025 11:43:18 GMT, fabioromano1 <duke at openjdk.org> wrote:
>> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
>>
>> make magBitLength() an instance method
>
> src/java.base/share/classes/java/math/BigInteger.java line 3619:
>
>> 3617: int nzInts = numberOfTrailingZeroInts();
>> 3618: if (nInts > nzInts || nInts == nzInts
>> 3619: && nBits > Integer.numberOfTrailingZeros(magLen - 1 - nzInts)) {
>
> @rgiulietti The bug was there.
OK, good.
We try to make sure that pushed commits pass all the relevant tests.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25166#discussion_r2092892266
More information about the core-libs-dev
mailing list