RFR: 8351230: Collections.synchronizedList returns a list that is not thread-safe [v2]

Stuart Marks smarks at openjdk.org
Sat May 17 01:02:03 UTC 2025


On Fri, 16 May 2025 09:24:13 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Stuart Marks has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reversed view of SynchronizedRandomAccessList should also be RandomAccess.
>>   Add tests to ensure RandomAccess is preserved when reversing.
>
> test/jdk/java/util/Collections/SyncListBash.java line 31:
> 
>> 29:  * @run     main SyncListBash f
>> 30:  * @run     main SyncListBash r
>> 31:  * @summary Test that List's new SequencedCollection methods are properly
> 
> Nit - jtreg recommends `@summary` to be after `@bug` https://openjdk.org/jtreg/tag-spec.html#ORDER. It would be good to follow that for this new test.

Oh, thanks for pointing this out. I'll fix.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24990#discussion_r2093806293


More information about the core-libs-dev mailing list