RFR: 8351230: Collections.synchronizedList returns a list that is not thread-safe [v3]

[Jaikiran Pai]

On Sat, 17 May 2025 01:25:14 GMT, Stuart Marks <smarks at openjdk.org> wrote:

>> Collections.synchronizedList() returns a List implementation that doesn't do proper locking. This PR does the following on the synchronized wrapper:
>> 
>> - overrides and adds locking to SequencedCollection methods;
>> - performs instance management of reversed synchronized views;
>> - adds test for race conditions and functional tests of synchronized wrappers.
>
> Stuart Marks has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8351230-synchronized-list
>  - Adjust @summary line in test.
>  - Reversed view of SynchronizedRandomAccessList should also be RandomAccess.
>    Add tests to ensure RandomAccess is preserved when reversing.
>  - moar comments
>  - Various tweaks.
>  - fix for synch list
>  - fix copyright line
>  - tests for synch list

Thank you for the update, Stuart. This looks good to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24990#pullrequestreview-2847863986