RFR: 8356891: Some code simplifications for basic BigIntegers' bit operations [v8]

[Raffaello Giulietti]

On Mon, 19 May 2025 15:02:57 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   An optimization
>
> src/java.base/share/classes/java/math/BigInteger.java line 5034:
> 
>> 5032:      */
>> 5033:     private byte[] magSerializedForm() {
>> 5034:         byte[] result = new byte[(magBitLength() + 7) >>> 3];
> 
> I think there's a risk of overflow, so consider
> Suggestion:
> 
>         byte[] result = new byte[(magBitLength() - 1 >>> 3) + 1];

Ah no, there's a unsigned shift `>>>`.
Disregard

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25166#discussion_r2095922459