RFR: 8355954: File.delete removes read-only files (win) [v4]

Alan Bateman alanb at openjdk.org
Mon May 19 15:59:59 UTC 2025


On Mon, 19 May 2025 15:20:25 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Split the test method in half for Unix and Windows in [fa2273e](https://github.com/openjdk/jdk/pull/24977/commits/fa2273eded040a22c1e32ba8870571d3a7daf427).
>
>> The behavior and system property is Windows specific and might make things simpler to make it a Windows only test.
> 
> I think I might have misunderstood this comment. Was the intent to make this test use `@requires os.family == "windows"`?

I think that would be simpler and means the `@EnabledOnOs` usages would go away, but it's up to you.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24977#discussion_r2096050597


More information about the core-libs-dev mailing list