RFR: 8356891: Some code simplifications for basic BigIntegers' bit operations [v6]

fabioromano1 duke at openjdk.org
Mon May 19 17:19:53 UTC 2025


On Mon, 19 May 2025 15:50:10 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> What is the usefulness of doing `int[] mag = this.mag;` at line 3856, since `bitLength()` does not access to `static` fields and `BigInteger` is not threadsafe, and therefore no race conditions occur?
>
> I think the suggestion is fine.

Yes, but perhaps in the current version it's more clear what is the returned value according to the condition.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25166#discussion_r2096183726


More information about the core-libs-dev mailing list