RFR: 8344332: (bf) Migrate DirectByteBuffer away from jdk.internal.ref.Cleaner [v2]

Kim Barrett kbarrett at openjdk.org
Mon May 19 20:46:55 UTC 2025


On Mon, 19 May 2025 19:24:57 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move jdk.internal.nio.Cleaner to sun.nio
>
> src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template line 88:
> 
>> 86:                 // Long-standing behavior: when deallocation fails, VM exits.
>> 87:                 if (System.err != null) {
>> 88:                     new Error("Cleaner terminated abnormally", x).printStackTrace();
> 
> The message would be more useful to identify this as a **Buffer** Cleaner terminated abnormally.

This code was cribbed from https://github.com/openjdk/jdk/pull/22165, but your suggestion has led me to
discover that wasn't right. I'm going to need to do some rework of the exception handling around cleaning.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25289#discussion_r2096460505


More information about the core-libs-dev mailing list