RFR: 8355223: Improve documentation on @IntrinsicCandidate [v6]
Jaikiran Pai
jpai at openjdk.org
Tue May 20 06:10:55 UTC 2025
On Wed, 30 Apr 2025 22:26:30 GMT, Chen Liang <liach at openjdk.org> wrote:
>> In offline discussion, we noted that the documentation on this annotation does not recommend minimizing the intrinsified section and moving whatever can be done in Java to Java; thus I prepared this documentation update, to shrink a "TLDR" essay to something concise for readers, such as pointing to that list at `vmIntrinsics.hpp` instead of "a list".
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>
> - Move intrinsic to be a subsection; just one most common function of the annotation
> - Merge branch 'master' of https://github.com/openjdk/jdk into doc/intrinsic-candidate
> - Merge branch 'master' of https://github.com/openjdk/jdk into doc/intrinsic-candidate
> - Update src/java.base/share/classes/jdk/internal/vm/annotation/IntrinsicCandidate.java
>
> Co-authored-by: Raffaello Giulietti <raffaello.giulietti at oracle.com>
> - Shorter first sentence
> - Updates, thanks to John
> - Refine validation and defensive copying
> - 8355223: Improve documentation on @IntrinsicCandidate
src/java.base/share/classes/jdk/internal/vm/annotation/IntrinsicCandidate.java line 39:
> 37: * <h2 id="intrinsification">Intrinsification</h2>
> 38: * The most frequently special treatment is intrinsification, which replaces a
> 39: * candidate method's body, bytecode or native, with handwritten platform
Is this sentence missing the word "code" after "native"? Should it have been:
> bytecode or native code, ...
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24777#discussion_r2097002980
More information about the core-libs-dev
mailing list