RFR: 8355223: Improve documentation on @IntrinsicCandidate [v6]
Jaikiran Pai
jpai at openjdk.org
Tue May 20 06:10:56 UTC 2025
On Fri, 16 May 2025 19:55:58 GMT, John R Rose <jrose at openjdk.org> wrote:
>> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>>
>> - Move intrinsic to be a subsection; just one most common function of the annotation
>> - Merge branch 'master' of https://github.com/openjdk/jdk into doc/intrinsic-candidate
>> - Merge branch 'master' of https://github.com/openjdk/jdk into doc/intrinsic-candidate
>> - Update src/java.base/share/classes/jdk/internal/vm/annotation/IntrinsicCandidate.java
>>
>> Co-authored-by: Raffaello Giulietti <raffaello.giulietti at oracle.com>
>> - Shorter first sentence
>> - Updates, thanks to John
>> - Refine validation and defensive copying
>> - 8355223: Improve documentation on @IntrinsicCandidate
>
> src/java.base/share/classes/jdk/internal/vm/annotation/IntrinsicCandidate.java line 47:
>
>> 45: * intrinsics necessary.
>> 46: * <p>
>> 47: * Intrinsification may never happen, or happen at any moment during execution.
>
> s/or happen/or may happen/ (easier to parse)
Hello John, are there are any hotspot VM flags that can be enabled to check whether or not intrinsification happen for a particular method during the lifetime of an application? Should any of those flags be documented in this proposed text?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24777#discussion_r2097001318
More information about the core-libs-dev
mailing list