RFR: 8354724: Methods in java.io.Reader to read all characters and all lines [v22]

Brian Burkhalter bpb at openjdk.org
Tue May 20 17:35:14 UTC 2025


On Mon, 19 May 2025 07:15:00 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Thank you Brian, the updated text for this section looks good to me. Once this PR gets integrated, I'll go through the Files.readXXX methods and file an issue to have that text simplified too.
>
> I see this has been changed to  "then some characters, but not all" but it doesn't flow very well. The original sentence, which was copied/modified from InputStream.readAllBytes, is much cleaner and I think I would prefer to go back to that.  Maybe Jai's issue could be address by dropping the first comma from the sentence?

In 0880af2 reverted previous commit then removed first comma from the modified sentence.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24728#discussion_r2098520689


More information about the core-libs-dev mailing list