RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v9]

[Henry Jen]

On Tue, 20 May 2025 18:30:46 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> We report all issues, not just one, so that would also involve what do we prioritized for the exit code...
>> In general, a non-zero code for invalid jar needs attention. We still 0 with unmatched order.
>> Also the process could fail with other issues like I/O or non-zip file.
>
> Yes I understand and currently we have no documentation as to what the return values might be.  An inconsistency in the order should also be 1 based we only return a 0 if there are no issues.  Any warning should be treated the same
> 
> My point is that it is worth considering with these changes

Point taken. For documentation wise, I don't think it's necessary to specify at this point.
For the inconsistent order in the LOC and CEN, we can treat it as invalid, I chose not to because that's not a violation, but if we do extend that as specification for JAR file format, then we can change that to invalid and non-zero exit code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24430#discussion_r2098943146