RFR: 8356985: Use "stdin.encoding" in Console's read*() methods [v3]

Justin Lu jlu at openjdk.org
Wed May 21 18:09:52 UTC 2025


On Wed, 21 May 2025 16:54:22 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Actually providing mock charset was a workaround of not having public method for getting the input encoding. I think it would be an overkill to introduce a new public method because it will not be used much, as most cases are suffice with the existing one (Console is used for interactive user enviornment, and I don't believe users would like to see different characters displayed for the input).
>
>> There is script.exp, but it tests sun.stdout.encoding, not stdout.encoding.
> 
> It is addressed in this PR

I think the JBS bug ID needs to be added to `CharsetTest.java` as well then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25271#discussion_r2100890130


More information about the core-libs-dev mailing list