RFR: 8356128: Correct documentation for --linux-package-deps [v3]
Alexander Matveev
almatvee at openjdk.org
Wed May 21 20:54:54 UTC 2025
On Wed, 21 May 2025 12:41:24 GMT, Stefan Lobbenmeier <duke at openjdk.org> wrote:
>> The documentation suggests that --linux-package-deps is a boolean option, while in fact it is a string option with dependencies separated by comma and space
>>
>> You can tell that this option is supposed to have an argument here: https://github.com/openjdk/jdk/blob/fea5f2b1458cdd53f437e59caaffaa6e22fb59a7/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxPackageBundler.java#L366-L372
>
> Stefan Lobbenmeier has updated the pull request incrementally with one additional commit since the last revision:
>
> also use <package-dep-string> in other locations
src/jdk.jpackage/share/man/jpackage.md line 426:
> 424: : Menu group this application is placed in
> 425:
> 426: <a id="option-linux-package-deps">`--linux-package-deps *package-dep-string*`</a>
Should it be "`--linux-package-deps *package-dep-string*`" -> "`--linux-package-deps` *package-dep-string*" similar to other options like `--linux-menu-group`. "``" around option only.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23638#discussion_r2101143417
More information about the core-libs-dev
mailing list