RFR: 8354724: Methods in java.io.Reader to read all characters and all lines [v25]
Roger Riggs
rriggs at openjdk.org
Wed May 21 21:08:01 UTC 2025
On Wed, 21 May 2025 19:18:03 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 29 additional commits since the last revision:
>
> - 8354724: Update API notes
> - Merge
> - 8354724: Revert previous commit and remove first comma in the change
> - 8354724: Improve verbiage about I/O errors
> - 8354724: Replace getChars in previous commit with subSequence
> - 8354724: Improve readAllAsString method of Reader returned by Reader.of
> - 8354724: Change readAllCharsAsString as suggested; move test to proper location
> - 8354724: "stream" -> "reader"
> - 8354724: Attempt to further improve verbiage
> - Merge
> - ... and 19 more: https://git.openjdk.org/jdk/compare/b2ecf232...f9c732eb
Looks good as a straightforward convenience for getting lines or a string from a Reader.
-------------
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24728#pullrequestreview-2859115874
More information about the core-libs-dev
mailing list